[asterisk-bugs] [Asterisk 0016945]: [patch] fix getting callerid name in imap_retrieve_file() (broken callerid number announcement/reply/...)

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16945 
====================================================================== 
Reported By:                mneuhauser
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16945
Category:                   Applications/app_voicemail/IMAP
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 249845 
Request Review:              
====================================================================== 
Date Submitted:             2010-03-02 12:24 CST
Last Modified:              2010-03-03 09:08 CST
====================================================================== 
Summary:                    [patch] fix getting callerid name in
imap_retrieve_file() (broken callerid number announcement/reply/...)
Description: 
The function imap_retrieve_file() uses get_header_by_tag() to retrieve
various headers from the mail in the IMAP storage and creates a temporary
file from these values. The get_header_by_tag() function uses a global
buffer to return its result but for the callerid, imap_retrieve_file()
calls this function twice, retrieving the number AND the name and only then
creates combined callerid, but at this point, both the name and the number
point into the global buffer which holds the last result, i.e., both are
the same string (the name, since this was retrieved last).

The fix just saves the number with ast_strdupa() before calling
get_header_by_tag() to retrieve the name.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-03 09:08 lmadsen        Status                   new => ready for
testing
======================================================================