[asterisk-bugs] [Asterisk 0016844]: [patch] Fix portability bit fields and make "mfcr2_immediate_accept" work again

Wed Mar 3 08:59:15 CST 2010

The following issue has been CLOSED 
====================================================================== 
https://issues.asterisk.org/view.php?id=16844 
====================================================================== 
Reported By:                korihor
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16844
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-929 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 246942 
Request Review:              
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-02-16 12:54 CST
Last Modified:              2010-03-03 08:59 CST
====================================================================== 
Summary:                    [patch] Fix portability bit fields and make
"mfcr2_immediate_accept" work again
Description: 
First, because in C the "bit fields" are "implementation-defined" when a
member is declared as type "int". It is recommended to explicitly specify
"signed" or "unsigned" on this members for portability.

Second, the variables "get_ani_first", "skip_category_request",
"immediate_accept" contain over his life three possible values: -1, 0, 1.
They therefore have to be members type "signed int" 2-bit (: 2). The rest
can only be 0 or 1, so they are "unsigned int" 1-bit (: 1).
====================================================================== 

---------------------------------------------------------------------- 
 (0118826) lmadsen (administrator) - 2010-03-03 08:59
 https://issues.asterisk.org/view.php?id=16844#c118826 
---------------------------------------------------------------------- 
Fixed per moy. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-03 08:59 lmadsen        Note Added: 0118826                          
2010-03-03 08:59 lmadsen        Status                   ready for testing =>
closed
======================================================================