[asterisk-bugs] [Asterisk 0016878]: [patch] Cleanup transmit_displaymessage

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16878 
====================================================================== 
Reported By:                wedhorn
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   16878
Category:                   Channels/chan_skinny
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 248184 
Request Review:              
====================================================================== 
Date Submitted:             2010-02-21 14:05 CST
Last Modified:              2010-03-01 13:33 CST
====================================================================== 
Summary:                    [patch] Cleanup transmit_displaymessage
Description: 
This patch splits transmit_displaymessage into
transmit_clear_display_message and transmit_display_message which better
aligns with the skinny protocol. The new transmit_display_message is not
used in the current code, but will be and so it is commented.

Moved handle_datetime from this function to onhook and offhook functions
(display now properly cleared at the end of a call on 30VIP).

Removed skinny debug messages from inline code as there's an ast_verb in
transmit_clear_display_message. Also, removed commentary that it was a
clear display as it is now apparent from the function name.
====================================================================== 

---------------------------------------------------------------------- 
 (0118704) svnbot (reporter) - 2010-03-01 13:33
 https://issues.asterisk.org/view.php?id=16878#c118704 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 249670

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r249670 | mvanbaak | 2010-03-01 13:33:26 -0600 (Mon, 01 Mar 2010) | 17
lines

Cleanup display_*message functions.

This patch splits transmit_displaymessage into
transmit_clear_display_message and transmit_display_message which better
aligns with the skinny protocol. The new transmit_display_message is not
used in the current code, but will be and so it is commented.

Moved handle_datetime from this function to onhook and offhook functions
(display now properly cleared at the end of a call on 30VIP).

Removed skinny debug messages from inline code as there's an ast_verb in
transmit_clear_display_message. Also, removed commentary that it was a
clear display as it is now apparent from the function name.

Split transmit_displaypromptmessage into display and clear.

(closes issue https://issues.asterisk.org/view.php?id=16878)
Reported by: wedhorn
Patches: 
	skinny-clean02.diff uploaded by wedhorn (license 30)
	skinny-clean03.diff uploaded by wedhorn (license 30)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=249670 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-01 13:33 svnbot         Note Added: 0118704                          
======================================================================