[asterisk-bugs] [Asterisk 0017518]: Norwegian language - wrong word

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17518 
====================================================================== 
Reported By:                MariusSM
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17518
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.8 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-06-17 03:44 CDT
Last Modified:              2010-06-18 01:41 CDT
====================================================================== 
Summary:                    Norwegian language - wrong word
Description: 
When calling voicemailmain(), and having no messages, a wrong word is
pronounced.

In english, the phrase says:
"You have no messages", which should translate to "Du har ingen meldinger"
in norwegian. What it actually says now is "Du har nei meldinger", which is
the direct (but wrong) translation.

"Du har nei meldinger" - "Nei" is the oposit of yes, it's like saying "you
have nothing messages".
"Du har ingen meldinger" - Is like saying you don't have any messages

I app_voicemail.c, vm_intro_no() should be changed:
        if (!vms->oldmessages && !vms->newmessages &&
!vms->urgentmessages) {
                res = ast_play_and_wait(chan, "vm-no");
                res = res ? res : ast_play_and_wait(chan, "vm-messages");
                return res;
        }


To:
        if (!vms->oldmessages && !vms->newmessages &&
!vms->urgentmessages) {
                res = ast_play_and_wait(chan, "vm-ingen");
                res = res ? res : ast_play_and_wait(chan, "vm-messages");
                return res;
        }


This will break existing voicemail-configurations, if they have recorded
"ingen" into the vm-no.gsm file.
====================================================================== 

---------------------------------------------------------------------- 
 (0123567) MariusSM (reporter) - 2010-06-18 01:41
 https://issues.asterisk.org/view.php?id=17518#c123567 
---------------------------------------------------------------------- 
Might I suggest the following:


        if (!vms->oldmessages && !vms->newmessages &&
!vms->urgentmessages) {
                /* Fix for correct language, without breaking previous
behaviour */
                if(ast_fileexists("vm-ingen",NULL,"no")) {
                        res = ast_play_and_wait(chan, "vm-ingen");
                } else {
                        res = ast_play_and_wait(chan, "vm-no");
                }
                res = res ? res : ast_play_and_wait(chan, "vm-messages");
                return res;
        }


This will NOT break current behaviour. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-18 01:41 MariusSM       Note Added: 0123567                          
======================================================================