[asterisk-bugs] [Asterisk 0017506]: MSG_OOB flag on HANGUP packet misused

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17506 
====================================================================== 
Reported By:                brycebaril
Assigned To:                pabelanger
====================================================================== 
Project:                    Asterisk
Issue ID:                   17506
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           Older 1.6.2 - please test a newer version 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-06-14 15:51 CDT
Last Modified:              2010-06-16 13:50 CDT
====================================================================== 
Summary:                    MSG_OOB flag on HANGUP packet misused
Description: 
When using fast AGI and the AGISIGHUP flag is enabled, Asterisk sends an
Out-of-Band "HANGUP\n" packet when the channel is terminated.  It uses the
MSG_OOB flag to send it URG/Out-of-Band via TCP.

This TCP feature is generally not used and not reliable (e.g.
http://en.wikipedia.org/wiki/Transmission_Control_Protocol#Out_of_band_data
) and in this case will cause only the "\n" character to be sent OOB.  The
"HANGUP" is still sent in-band, and can cause buffering issues --
especially with the "\n" being sent in a different band.  

Even if the developer sets socket options to get the OOB data in-band, the
"\n" will come in prior to the "HANGUP" because it is a higher priority.

I suggest dropping the "MSG_OOB" flag from this packet, as it doesn't seem
to do any good, and possibly only does harm.
====================================================================== 

---------------------------------------------------------------------- 
 (0123490) svnbot (reporter) - 2010-06-16 13:50
 https://issues.asterisk.org/view.php?id=17506#c123490 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 270937

_U  branches/1.6.2/
U   branches/1.6.2/CHANGES
U   branches/1.6.2/res/res_agi.c

------------------------------------------------------------------------
r270937 | pabelanger | 2010-06-16 13:50:10 -0500 (Wed, 16 Jun 2010) | 15
lines

Merged revisions 270936 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r270936 | pabelanger | 2010-06-16 14:43:22 -0400 (Wed, 16 Jun 2010) | 8
lines
  
  MSG_OOB flag on HANGUP packet removed.
  
  Per Tilghman's request on IRC (#asterisk-bugs).
  
  (closes issue https://issues.asterisk.org/view.php?id=17506)
  Reported by: brycebaril
  Tested by: pabelanger, tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=270937 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-16 13:50 svnbot         Checkin                                      
2010-06-16 13:50 svnbot         Note Added: 0123490                          
======================================================================