[asterisk-bugs] [Asterisk 0017473]: mistakes in the 1.4.19 core-sounds-en.txt file

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17473 
====================================================================== 
Reported By:                murf
Assigned To:                lmadsen
====================================================================== 
Project:                    Asterisk
Issue ID:                   17473
Category:                   Sounds
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 265271 
Request Review:              
====================================================================== 
Date Submitted:             2010-06-05 10:48 CDT
Last Modified:              2010-06-10 10:51 CDT
====================================================================== 
Summary:                    mistakes in the 1.4.19 core-sounds-en.txt file
Description: 
1. missing entries  (the sound file exists, but not recorded in the .txt
file)
   a. dir-first: ... letters of your party's first name
   b. digits/billion.wav:   billion

2. non-existent entries (the sound file referenced isn't there!)
   a. phonetic/niner    (phonetic/9_p  says "niner")
   b. dollars           (digits/dollars  says "dollars")

And that's all for the obvious errors. I haven't listened to all 450 or so
sounds to verify that the scripts are correct yet. If I do, and find a
prob, I'll file a separate bug report.
====================================================================== 

---------------------------------------------------------------------- 
 (0123241) murf (manager) - 2010-06-10 10:51
 https://issues.asterisk.org/view.php?id=17473#c123241 
---------------------------------------------------------------------- 
Yes, the chkcore script is pretty minimal. It only checks to make sure any
.wav
file in the top level dir has an entry in the .txt file; it does not do
the reverse check, that of making sure all files listed in the .txt file do
indeed exist. That's why the dollars.wav and phonetic/niner weren't
spotted. 

The other two are also easy to explain. For the "dir-first" it found  the
"dir-firstlast" entry instead, and was satisfied, and the phonetic/niner
was missed because the script doesn't check the files in the subdirs like
digits, phonetic, etc.

Both problems, I would think, would be easy to fix in the script;
explicitly add the subdirs to the list for the for loop, and not get rid of
the subdir in the base pattern match, and end the pattern match with a : to
stop matching a partial file name.

Then you'd have to code up the reverse search; for each line in the .txt
file,
grab the file name and find it, reporting files not found.


I've written my own checking program in C; It runs the above checks both
ways and reports discrepancies. And, then it goes thru the files one at a
time, listing them by number, name, and contents, then playing each one. It
waits in between for commands to play, replay, list, jump, and quit. It
will accept
multiple play commands on one line to expedite the process; you can play 4
or 10 in a row, and check them off.

This way, I can also verify that the scripts match the sound files. For
instance, the script file says "conf-roll-callcomplete: Roll call
complete.",
but it really says something else, and vm-intro says "vm-intro: Please
leave your message after the tone.  When done hang up or press the pound
key. (simple tone sound plays)", but no simple tone ends the message.

I'd attach it to the bug here for general usage, but somehow I picture you
guys wanting to just upgrade the script instead; it doesn't need to be
compiled and would be less trouble. My program requires me to clean any
blank lines and comments out of the the .txt file before running (to keep
down any error messages.) and I know there's a range violation or two left
in my code, but really, I don't care. It's sloppy but sufficient for me. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-10 10:51 murf           Note Added: 0123241                          
======================================================================