[asterisk-bugs] [LibPRI 0017405]: BRI TE assignment logic is absolutely wrong.

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17405 
====================================================================== 
Reported By:                ddv2005
Assigned To:                mattf
====================================================================== 
Project:                    LibPRI
Issue ID:                   17405
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           Addons-1.6.1 - SECURITY ONLY! 
JIRA:                        
libpri Version:             I did not set the version. :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 no change required
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-05-26 12:51 CDT
Last Modified:              2010-06-10 10:42 CDT
====================================================================== 
Summary:                    BRI TE assignment logic is absolutely wrong.
Description: 
BRI TE assignment logic is absolutely wrong. Usually each BRI port have 2
BRI channels. For BRI NT PTMP mode each channel request separate D-Channel
by sending Q921_TEI_IDENTITY_REQUEST. And BRI NT software MUST support
several subchannels. But your implementation does not support more than one
subchannel. Your implementation for Q921_TEI_IDENTITY_REMOVE/
Q921_TEI_IDENTITY_ASSIGNED/ Q921_TEI_IDENTITY_CHECK_REQUEST look depth only
at one subchannel. Like this:
=============================================================
	case Q921_TEI_IDENTITY_REMOVE:
		if (!BRI_TE_PTMP(pri))
			return NULL;

		if ((tei == Q921_TEI_GROUP) || (tei == pri->subchannel->tei)) {
			q921_setstate(pri->subchannel, Q921_TEI_UNASSIGNED);
			q921_start(pri->subchannel);
		}
=============================================================
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016587 [patch] BRI Network side PTMP mode. Sup...
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-10 10:42 mattf          Status                   feedback => resolved
2010-06-10 10:42 mattf          Resolution               open => no change
required
2010-06-10 10:42 mattf          Assigned To               => mattf           
2010-06-10 10:42 mattf          Status                   resolved => closed  
======================================================================