[asterisk-bugs] [LibPRI 0017405]: BRI TE assignment logic is absolutely wrong.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17405 
====================================================================== 
Reported By:                ddv2005
Assigned To:                
====================================================================== 
Project:                    LibPRI
Issue ID:                   17405
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           Addons-1.6.1 - SECURITY ONLY! 
JIRA:                        
libpri Version:             I did not set the version. :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-26 12:51 CDT
Last Modified:              2010-06-10 10:41 CDT
====================================================================== 
Summary:                    BRI TE assignment logic is absolutely wrong.
Description: 
BRI TE assignment logic is absolutely wrong. Usually each BRI port have 2
BRI channels. For BRI NT PTMP mode each channel request separate D-Channel
by sending Q921_TEI_IDENTITY_REQUEST. And BRI NT software MUST support
several subchannels. But your implementation does not support more than one
subchannel. Your implementation for Q921_TEI_IDENTITY_REMOVE/
Q921_TEI_IDENTITY_ASSIGNED/ Q921_TEI_IDENTITY_CHECK_REQUEST look depth only
at one subchannel. Like this:
=============================================================
	case Q921_TEI_IDENTITY_REMOVE:
		if (!BRI_TE_PTMP(pri))
			return NULL;

		if ((tei == Q921_TEI_GROUP) || (tei == pri->subchannel->tei)) {
			q921_setstate(pri->subchannel, Q921_TEI_UNASSIGNED);
			q921_start(pri->subchannel);
		}
=============================================================
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016587 [patch] BRI Network side PTMP mode. Sup...
====================================================================== 

---------------------------------------------------------------------- 
 (0123237) mattf (administrator) - 2010-06-10 10:41
 https://issues.asterisk.org/view.php?id=17405#c123237 
---------------------------------------------------------------------- 
That is correct.  We also do not support US style BRI either in current
versions of libpri (as you well know).

For future reference, please do not submit bug reports for unimplemented
functionality or features (such as the additions and modifications
necessary for libpri to support US style BRI).

Any discussions related to this either need to be in the form of the
patches and comments on bug https://issues.asterisk.org/view.php?id=16587 or on
the asterisk-dev mailing list.

Sorry about the trouble, it's just that the bug tracker stays full enough
as it is, and we need to make sure that it's easy to separate signal and
noise on the issues that are on it.

On that note, I'm going to close this issue. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-10 10:41 mattf          Note Added: 0123237                          
======================================================================