[asterisk-bugs] [DAHDI-linux 0017382]: [patch] Failure to include semaphore.h breaks compilation with >2.6.34 kernels (2.6.35-rc0)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17382 
====================================================================== 
Reported By:                Chainsaw
Assigned To:                tzafrir
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   17382
Category:                   dahdi (the module)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2010-05-24 10:56 CDT
Last Modified:              2010-06-08 14:09 CDT
====================================================================== 
Summary:                    [patch] Failure to include semaphore.h breaks
compilation with >2.6.34 kernels (2.6.35-rc0)
Description: 
DAHDI relied on other headers to drag in semaphore.h, this is no longer the
case since:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3142788b7967ccfd2f1813ee9e11aeb1e1cf7de2

The result is:
In file included from
/var/tmp/portage/net-misc/dahdi-2.3.0/work/dahdi-linux-2.3.0/drivers/dahdi/voicebus/GpakApi.c:36:
/var/tmp/portage/net-misc/dahdi-2.3.0/work/dahdi-linux-2.3.0/drivers/dahdi/voicebus/GpakCust.h:114:
error: field ‘sem’ has incomplete type

Patching the header to include semaphore.h as it should always have done
will not hurt older kernels.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017383 [patch] usb_buffer_free/alloc renamed i...
====================================================================== 

---------------------------------------------------------------------- 
 (0123147) svnbot (reporter) - 2010-06-08 14:09
 https://issues.asterisk.org/view.php?id=17382#c123147 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 8758

U   linux/trunk/drivers/dahdi/voicebus/GpakCust.h

------------------------------------------------------------------------
r8758 | tzafrir | 2010-06-08 14:09:09 -0500 (Tue, 08 Jun 2010) | 11 lines

include semaphore.h explicitly for newer kernels

With kernel version >= 2.6.35-rc1, building failed with:

  drivers/dahdi/voicebus/GpakCust.h:114: error: field
?\226?\128?\152sem?\226?\128?\153 has incomplete type

(closes issue https://issues.asterisk.org/view.php?id=17382)
Reported by: Chainsaw
Patches:
      07-semaphore-include-not-optional.diff uploaded by Chainsaw (license
723)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=8758 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-08 14:09 svnbot         Checkin                                      
2010-06-08 14:09 svnbot         Note Added: 0123147                          
======================================================================