[asterisk-bugs] [Asterisk 0016320]: [patch] Incorrect reloading of realtime peer causes mailbox list to expand indefinitely

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16320 
====================================================================== 
Reported By:                Marquis
Assigned To:                pabelanger
====================================================================== 
Project:                    Asterisk
Issue ID:                   16320
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-1352 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/666/ 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 231169 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-24 18:22 CST
Last Modified:              2010-06-07 17:47 CDT
====================================================================== 
Summary:                    [patch] Incorrect reloading of realtime peer causes
mailbox list to expand indefinitely
Description: 
Due to the current code's inability to short-circuit the reloading of a
realtime peer when it's looking for a user, the mailbox list is repeatedly
appended to.

For example, if you issue a 'sip show peer 1234', you may get something
like:
Mailbox     : 1234 at default

But after any inbound peer match (resulting in a call to find_peer), it
will result in:
Mailbox     : 1234 at default, 1234 at default

And so on, ad infinitum.

This can cause a large number of NOTIFYs to be sent to the peer, in some
cases resulting in a phone crash or reboot.

There may be other effects, but this is the observed behavior.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016021 [patch] sippeers loaded with realtime a...
has duplicate       0017254 [patch] Multiple SIP NOTIFY packets sen...
related to          0017313 SIP NOTIFY bombardment after hangup voi...
====================================================================== 

---------------------------------------------------------------------- 
 (0123088) svnbot (reporter) - 2010-06-07 17:47
 https://issues.asterisk.org/view.php?id=16320#c123088 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 268817

U   trunk/channels/chan_sip.c
U   trunk/channels/sip/include/sip.h

------------------------------------------------------------------------
r268817 | tilghman | 2010-06-07 17:47:13 -0500 (Mon, 07 Jun 2010) | 9
lines

Mailbox list would previously grow at each reload, containing duplicates.

Also, optimize the allocation of mailboxes to avoid additional memory
structures.

(closes issue https://issues.asterisk.org/view.php?id=16320)
 Reported by: Marquis
 Patches: 
       20100525__issue16320.diff.txt uploaded by tilghman (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=268817 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-07 17:47 svnbot         Checkin                                      
2010-06-07 17:47 svnbot         Note Added: 0123088                          
======================================================================