[asterisk-bugs] [Asterisk 0016979]: contributed init.d file has wrong pid location

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16979 
====================================================================== 
Reported By:                jw-asterisk
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16979
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.5 
JIRA:                       SWP-1046 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-03-06 21:52 CST
Last Modified:              2010-06-06 00:31 CDT
====================================================================== 
Summary:                    contributed init.d file has wrong pid location
Description: 
In contrib/init.d/rc.redhat.asterisk the location of the pid file doesn't
match what is in the default asterisk.conf.

In asterisk.conf there is a "astrundir=/var/run/asterisk" therefore by
default the asterisk pid will be stored in /var/run/asterisk/asterisk.pid.

Therefore in contrib/init.d/rc.redhat.asterisk there should be a line:

<pre>
   # pidfile: /var/run/asterisk/asterisk.pid
</pre>

But unfortunately the killproc function will not know where the pid is
stored.  So the following should be added/changed also:

<pre>
   piddir=`awk '$1=="astrundir"{print $3}' $AST_CONFIG`
   ...
   killproc -p $piddir/asterisk.pid `basename $DAEMON`
</pre>

Otherwise asterisk will never get terminated properly.



======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0015691 [patch] Modify init-scripts for better ...
====================================================================== 

---------------------------------------------------------------------- 
 (0123024) svnbot (reporter) - 2010-06-06 00:31
 https://issues.asterisk.org/view.php?id=16979#c123024 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 268535

_U  branches/1.6.2/
U   branches/1.6.2/contrib/init.d/rc.redhat.asterisk

------------------------------------------------------------------------
r268535 | tilghman | 2010-06-06 00:31:11 -0500 (Sun, 06 Jun 2010) | 15
lines

Merged revisions 268534 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r268534 | tilghman | 2010-06-06 00:29:50 -0500 (Sun, 06 Jun 2010) | 8
lines
  
  Take advantage of variable substitution already in the Makefile to
specify the correct location for files in init.d.
  
  (closes issue https://issues.asterisk.org/view.php?id=16979)
   Reported by: jw-asterisk
   
  (issue https://issues.asterisk.org/view.php?id=15691)
   Reported by: itamarjp
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=268535 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-06 00:31 svnbot         Checkin                                      
2010-06-06 00:31 svnbot         Note Added: 0123024                          
======================================================================