[asterisk-bugs] [Asterisk 0017371]: [patch] [regression] DAHDI analog FXS port segfaults after dialling 2nd DTMF digit

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17371 
====================================================================== 
Reported By:                alecdavis
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17371
Category:                   Core/PBX
Reproducibility:            always
Severity:                   crash
Priority:                   high
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                        
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 264905 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-21 04:14 CDT
Last Modified:              2010-06-05 12:55 CDT
====================================================================== 
Summary:                    [patch] [regression] DAHDI analog FXS port segfaults
after dialling 2nd DTMF digit
Description: 
https://issues.asterisk.org/view.php?id=1  0x080e12f4 in ast_dsp_process
(chan=0x85e23d8, dsp=0x85e5008,
af=0x85d1560) at dsp.c:1418
1418                                   
memmove(&dsp->digit_state.digitlen[0], &dsp->digit_state.digitlen[1],
dsp->digit_state.current_len * sizeof(dsp->digit_state.digitlen[0]));
(gdb) p  dsp->digit_state.current_len
$1 = 2
(gdb) p dsp->digit_state.digitlen[0]
$2 = 0
(gdb) p dsp->digit_state.digitlen[1]
$3 = 0
(gdb) quit

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017235 [patch] asterisk dsp always reports det...
has duplicate       0017417 segfault error. Asterisk crash.
has duplicate       0017474 [patch] Crash in dsp.c when entering di...
====================================================================== 

---------------------------------------------------------------------- 
 (0123012) svnbot (reporter) - 2010-06-05 12:55
 https://issues.asterisk.org/view.php?id=17371#c123012 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 268456

U   trunk/main/dsp.c

------------------------------------------------------------------------
r268456 | tilghman | 2010-06-05 12:55:27 -0500 (Sat, 05 Jun 2010) | 14
lines

Fix crash in DTMF detection.

What I did not originally see in my previous commit was that even though
the
next digit could be detected before the previous was considered ended, the
detection of the next digit effectively ends the detection of the
previous.
Therefore, the length moves in lockstep with the digit, and no separate
counter
is needed for the length alone.

(closes issue https://issues.asterisk.org/view.php?id=17371)
 Reported by: alecdavis

(closes issue https://issues.asterisk.org/view.php?id=17474)
 Reported by: kenner

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=268456 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-05 12:55 svnbot         Checkin                                      
2010-06-05 12:55 svnbot         Note Added: 0123012                          
======================================================================