[asterisk-bugs] [Asterisk 0017433]: [patch] DAHDI bridge can't fax pass through

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17433 
====================================================================== 
Reported By:                ddkprog
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17433
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                       SWP-1618 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-06-01 05:28 CDT
Last Modified:              2010-06-05 00:54 CDT
====================================================================== 
Summary:                    [patch] DAHDI bridge can't fax pass through
Description: 
iam realy suprised, why fax can't pass through inside DAHDI bridge
looking through chan_dahdi.c code
inside function dahdi_bridge
have a code
                f = ast_read(who);
                if (!f || (f->frametype == AST_FRAME_CONTROL)) {
                        *fo = f;
                        *rc = who;
                        res = AST_BRIDGE_COMPLETE;
                        goto return_from_bridge;
                }
                if (f->frametype == AST_FRAME_DTMF) {
                        if ((who == c0) && p0->pulsedial) {
                                ast_write(c1, f);
                        } else if ((who == c1) && p1->pulsedial) {
                                ast_write(c0, f);
                        } else {
                                *fo = f;
                                *rc = who;
                                res = AST_BRIDGE_COMPLETE;
                                goto return_from_bridge;
                        }
                }
                ast_frfree(f);

                /* Swap who gets priority */
                priority = !priority;

i see that only the SIGNAL FRAMES can pass
====================================================================== 

---------------------------------------------------------------------- 
 (0123000) ddkprog (reporter) - 2010-06-05 00:54
 https://issues.asterisk.org/view.php?id=17433#c123000 
---------------------------------------------------------------------- 
version does not have a value
bug is present in all versions of chan_zap.c/chan_dahdi.c
this patch fixit version svn trunk chan_dadi.c
I can not provide debug and configuration because I have not access to
equipment

but this patch is used for passing faxes in the channel dahdi in working
with channel bank where chan_dahdi channel operates as a function of
dahdi_bridge()
I think for the developer chan_dadhi this logic more than transparent
because frames T30/T31 are not AST_FRAME_CONTROL/AST_FRAME_DTMF
so at least the AST_FRAME_AUDIO and AST_FRAME_VIDEO should be pass
throught inside dahdi_bridge() function
the patch fixes this issue and frame T30/T31 will pass throught inside
DAHDI 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-05 00:54 ddkprog        Note Added: 0123000                          
======================================================================