[asterisk-bugs] [Asterisk 0016993]: [patch] MusicOnHold produces a crash

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16993 
====================================================================== 
Reported By:                dmitri
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16993
Category:                   Resources/res_musiconhold
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-1062 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 251399 
Request Review:              
====================================================================== 
Date Submitted:             2010-03-09 02:29 CST
Last Modified:              2010-06-04 17:19 CDT
====================================================================== 
Summary:                    [patch] MusicOnHold produces a crash
Description: 
MusicOnHold produces a crash on hangup when class configured in realtime
refers for non existing or an empty directory.
And this only happens when using cachertclasses flag in musiconhold.conf.
I made a patch for fixing this issue.
====================================================================== 

---------------------------------------------------------------------- 
 (0122995) dmitri (reporter) - 2010-06-04 17:19
 https://issues.asterisk.org/view.php?id=16993#c122995 
---------------------------------------------------------------------- 
Nope. In fact comment mark "XXX This code is impossible to reach" says true
and Your first added line will never been executed.
But if impossible becomes possible You just produce a new crash in

moh_register(mohclass, 0, DONT_UNREF);

cause mohclass is NULL now.

Btw only the last case (if MOH_CACHERTCLASSES is not set) Your code works
as needed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-04 17:19 dmitri         Note Added: 0122995                          
======================================================================