[asterisk-bugs] [Asterisk 0016320]: [patch] Incorrect reloading of realtime peer causes mailbox list to expand indefinitely

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16320 
====================================================================== 
Reported By:                Marquis
Assigned To:                pabelanger
====================================================================== 
Project:                    Asterisk
Issue ID:                   16320
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-1352 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/666/ 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 231169 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-24 18:22 CST
Last Modified:              2010-06-03 17:15 CDT
====================================================================== 
Summary:                    [patch] Incorrect reloading of realtime peer causes
mailbox list to expand indefinitely
Description: 
Due to the current code's inability to short-circuit the reloading of a
realtime peer when it's looking for a user, the mailbox list is repeatedly
appended to.

For example, if you issue a 'sip show peer 1234', you may get something
like:
Mailbox     : 1234 at default

But after any inbound peer match (resulting in a call to find_peer), it
will result in:
Mailbox     : 1234 at default, 1234 at default

And so on, ad infinitum.

This can cause a large number of NOTIFYs to be sent to the peer, in some
cases resulting in a phone crash or reboot.

There may be other effects, but this is the observed behavior.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016021 [patch] sippeers loaded with realtime a...
has duplicate       0017254 [patch] Multiple SIP NOTIFY packets sen...
related to          0017313 SIP NOTIFY bombardment after hangup voi...
====================================================================== 

---------------------------------------------------------------------- 
 (0122929) Marquis (reporter) - 2010-06-03 17:15
 https://issues.asterisk.org/view.php?id=16320#c122929 
---------------------------------------------------------------------- 
I haven't tested the patch with your new approach, but it looks reasonable
to me.  The only reservation I have is that the simpler approach treats the
*symptom* while my original patch fixes the root cause.

The only reason this might be materially different is if there are other,
unknown issues with the way realtime peers are being loaded.  I have
absolutely ZERO proof (or even idle speculation, based on a cursory glance
over the code) that this is the case, and so I'm happy with the new way. 
chan_sip is a wooly place... 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-03 17:15 Marquis        Note Added: 0122929                          
======================================================================