[asterisk-bugs] [Asterisk 0015807]: rtt should be stored as double in struct ast_rtp_instance_stats

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15807 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15807
Category:                   Core/RTP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                       SWP-1143 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 214938 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-01 09:36 CDT
Last Modified:              2010-06-02 14:23 CDT
====================================================================== 
Summary:                    rtt should be stored as double in struct
ast_rtp_instance_stats
Description: 
Hi!

AFAIS member "rtt" in struct ast_rtp_instance_stats stored the RTT in
seconds, using an usigned int. 

As RTTs usually are below 0.5 (at least on earth and for VoIP useable
links) this member is useless as it is always 0.

Shouldn't that be changed to double?
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015819 [patch] buggy output in "sip show ...
====================================================================== 

---------------------------------------------------------------------- 
 (0122833) tilghman (administrator) - 2010-06-02 14:23
 https://issues.asterisk.org/view.php?id=15807#c122833 
---------------------------------------------------------------------- 
klaus:  You wrote:
The last condition (combined >= 0 && combined == current_stat) IMO makes
no sense - I think this is a bug and should be:
   (combined >= 0 && combined == stat) 

Could you explain your logic?  Why do you think it makes no sense? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-02 14:23 tilghman       Note Added: 0122833                          
======================================================================