[asterisk-bugs] [Asterisk 0015860]: wrong parsing of received RTCP packets

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15860 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15860
Category:                   Core/RTP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-09 06:12 CDT
Last Modified:              2010-06-02 11:41 CDT
====================================================================== 
Summary:                    wrong parsing of received RTCP packets
Description: 
The code for parsing the RTCP packets is buggy. When an RTCP RR/SR frame is
handled, it expects some fields present although they are optional.

E.g. take a look at the RTCP packets in the attached pcap dump. The first
RTCP packet contains a RR without any RTP statistics data. Nevertheless
Asterisk sets the statistics, reading wrong data from the RTCP packet (the
following SDS).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015819 [patch] buggy output in "sip show ...
====================================================================== 

---------------------------------------------------------------------- 
 (0122797) klaus3000 (reporter) - 2010-06-02 11:41
 https://issues.asterisk.org/view.php?id=15860#c122797 
---------------------------------------------------------------------- 
I just checked trunk: Trunk does handle receiver-report with RC=0 correct -
due to the following code:

                if (rc == 0 && pt == RTCP_PT_RR) {      /* We're receiving
a receiver report with no reports, which is ok */
                        position += (length + 1);
                        continue;
                }

that should be added to older Asterisk versions too.

AFAIS there is still problems with SR and RC=0 in trunk. I will take a
look at Olle's branch (after the long weekend - public holiday in Austria) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-02 11:41 klaus3000      Note Added: 0122797                          
======================================================================