[asterisk-bugs] [Asterisk 0015996]: [patch] change the order for ACF registration for SMDI

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15996 
====================================================================== 
Reported By:                junky
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15996
Category:                   Resources/res_smdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
JIRA:                       SWP-1153 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 220792 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-09-30 21:54 CDT
Last Modified:              2010-06-01 13:02 CDT
====================================================================== 
Summary:                    [patch] change the order for ACF registration for
SMDI
Description: 

Right now, we're doing the registration for the ACF, then check the
validity of the SDMI.
This results in confusion for users:

Like:
before the patch:
shooter*CLI> module load res_smdi.so
Unable to load module res_smdi.so
Command 'module load res_smdi.so' failed.
  == Registered custom function 'SMDI_MSG_RETRIEVE'
  == Registered custom function 'SMDI_MSG'
  == Parsing '/etc/asterisk/smdi.conf':   == Found
  == Unregistered custom function SMDI_MSG_RETRIEVE
  == Unregistered custom function SMDI_MSG
[Sep 30 15:44:56] NOTICE[27241]: res_smdi.c:1420 load_module: No SMDI
interfaces are available to listen on, not starting SMDI listener.

Users are wondering: why do we register these 2 functions, then we are
unregister them?

This patch solves that "confusion":
shooter*CLI> module load res_smdi.so
Unable to load module res_smdi.so
Command 'module load res_smdi.so' failed.
  == Parsing '/etc/asterisk/smdi.conf':   == Found
[Sep 30 15:50:56] NOTICE[29186]: res_smdi.c:1418 load_module: No SMDI
interfaces are available to listen on, not starting SMDI listener.

====================================================================== 

---------------------------------------------------------------------- 
 (0122717) svnbot (reporter) - 2010-06-01 13:02
 https://issues.asterisk.org/view.php?id=15996#c122717 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 266735

U   trunk/res/res_smdi.c

------------------------------------------------------------------------
r266735 | tilghman | 2010-06-01 13:02:23 -0500 (Tue, 01 Jun 2010) | 7
lines

Don't register functions until the last possible point, so they're not
unloaded unnecessarily.

(closes issue https://issues.asterisk.org/view.php?id=15996)
 Reported by: junky
 Patches: 
       sdmi_wait.diff uploaded by junky (license 177)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=266735 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-01 13:02 svnbot         Note Added: 0122717                          
2010-06-01 13:02 svnbot         Status                   ready for review =>
assigned
2010-06-01 13:02 svnbot         Assigned To               => tilghman        
2010-06-01 13:02 svnbot         Status                   assigned => resolved
2010-06-01 13:02 svnbot         Resolution               open => fixed       
======================================================================