[asterisk-bugs] [LibPRI 0017428]: [patch] Regression in libpri 1.4.11 - handling ROSE

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17428 
====================================================================== 
Reported By:                patrol-cz
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   17428
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.7 
JIRA:                       SWP-1610 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-31 14:30 CDT
Last Modified:              2010-06-01 11:10 CDT
====================================================================== 
Summary:                    [patch] Regression in libpri 1.4.11 - handling ROSE
Description: 
I've upgraded libpri to 1.4.11 and I've found that I can't see the QSIG
calling name for incoming calls now. The problem is, that there is
an unknown/unhandled operation (85) before the Calling Name operation
(supplied by the interworking PBX), and libpri now fails to continue
interpreting the facility contents since it encounters the unknown
operation. In older libPRI (libpri-1.4.10.1) the problem is not present,
the parser just skips the unknown operation and continues, thus properly
parsing the Calling Name operation.

====================================================================== 

---------------------------------------------------------------------- 
 (0122700) patrol-cz (reporter) - 2010-06-01 11:10
 https://issues.asterisk.org/view.php?id=17428#c122700 
---------------------------------------------------------------------- 
The patch is working. libpri now processes the second INVOKE component as
well, causing the name being visible again. See debug:

-- Delayed processing IE 28 (cs0, Facility)
ASN.1 dump
  Context Specific/C [10 0x0A] <AA> Len:6 <06>
    Context Specific [0 0x00] <80> Len:1 <01>
      <00> - "~"
    Context Specific [2 0x02] <82> Len:1 <01>
      <00> - "~"
  Context Specific [11 0x0B] <8B> Len:1 <01>
    <00> - "~"
  Context Specific/C [1 0x01] <A1> Len:16 <10>
    Integer(2 0x02) <02> Len:1 <01>
      <01> - "~"
    Integer(2 0x02) <02> Len:1 <01>
      <55> - "U"
    Sequence/C(48 0x30) <30> Len:8 <08>
      Context Specific [2 0x02] <82> Len:3 <03>
        <01 30 40> - "~0@"an 1
      Context Specific [6 0x06] <86> Len:1 <01>
        <01> - "~"debug span 1
  Context Specific/C [1 0x01] <A1> Len:21 <15>
    Integer(2 0x02) <02> Len:1 <01>
      <02> - "~"o debug span 1
    Integer(2 0x02) <02> Len:1 <01>
      <00> - "~"o debug span 1
    Context Specific [0 0x00] <80> Len:13 <0D>
      <50 61 76 65 6C 20 54 72-6F 6C 6C 65 72> - "Pavel Troller"
ASN.1 end
  nfe NetworkFacilityExtension Context Specific/C [10 0x0A]
  sourceEntity Context Specific [0 0x00] = 0 0x0000
  destinationEntity Context Specific [2 0x02] = 0 0x0000
  interpretation Context Specific [11 0x0B] = 0 0x0000
INVOKE Component Context Specific/C [1 0x01]
  invokeId Integer(2 0x02) = 1 0x0001
  operationValue Integer(2 0x02) = 85 0x0055
  operationValue = ROSE_Unknown
  Skipping unused constructed component octets!
!! ROSE invoke operation not handled! ROSE_Unknown
INVOKE Component Context Specific/C [1 0x01]
  invokeId Integer(2 0x02) = 2 0x0002
  operationValue Integer(2 0x02) = 0 0x0000
  operationValue = ROSE_QSIG_CallingName
  callingName Name
  namePresentationAllowedSimple Context Specific [0 0x00] =
    <50 61 76 65 6C 20 54 72-6F 6C 6C 65 72> - "Pavel Troller" 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-01 11:10 patrol-cz      Note Added: 0122700                          
======================================================================