[asterisk-bugs] [Asterisk 0016046]: [patch] crash in ast_rtp_instance_early_bridge_make_compatible() when directmedia=yes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16046 
====================================================================== 
Reported By:                ebroad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16046
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-1958 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-08 16:50 CDT
Last Modified:              2010-07-28 16:21 CDT
====================================================================== 
Summary:                    [patch] crash in
ast_rtp_instance_early_bridge_make_compatible() when directmedia=yes
Description: 
Looks like glue1->get_codec() is null in
ast_rtp_instance_early_bridge_make_compatible.
====================================================================== 

---------------------------------------------------------------------- 
 (0125231) DEA (reporter) - 2010-07-28 16:21
 https://issues.asterisk.org/view.php?id=16046#c125231 
---------------------------------------------------------------------- 
The code is lifted out of chan_mgcp and nearly identical to
chan_sip.  I limited the changes to only identifying the
correct channel structure.

I assumed that the original author felt such tests to be
extranious.  I just checked the other six channels with this
function and they are basically identical to the proposed
addition.  Of note, I also see three other channels that
use rtp and lack this function, so are likely to segfault
if used-  chan_h323, chan_unistim and chan_multicast_rtp

I kind of like the sub->parent name, but I do not feel strongly
about it.  That whould be a seperate project/cleanup task? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-28 16:21 DEA            Note Added: 0125231                          
======================================================================