[asterisk-bugs] [Asterisk 0017621]: [patch] sounds/Makefile ignores checksum errors

Wed Jul 28 13:24:59 CDT 2010

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17621 
====================================================================== 
Reported By:                bjm
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   17621
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Target Version:             1.6.2.12
Asterisk Version:           SVN 
JIRA:                       SWP-1841 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 275549 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-11 19:07 CDT
Last Modified:              2010-07-28 13:24 CDT
====================================================================== 
Summary:                    [patch] sounds/Makefile ignores checksum errors
Description: 
While installing 1.6.2-SVN on OpenBSD 4.7, I got the disconcerting message
"/bin/sh: sha1sum: not found", yet the install continued.  The sha1sum
issue seems to be fixed in trunk,  but sounds/Makefile still ignores
errors. It emits the "Bad checksum:" message and exits 1, but inside a
subshell whose exit status is ignored.  So a symlink to the bad file is
created in sounds/, and a 0 status is returned to make, letting the install
continue with a dubious file in SOUNDS_CACHE_DIR.
====================================================================== 

---------------------------------------------------------------------- 
 (0125208) svnbot (reporter) - 2010-07-28 13:24
 https://issues.asterisk.org/view.php?id=17621#c125208 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 280196

_U  trunk/
U   trunk/sounds/Makefile

------------------------------------------------------------------------
r280196 | qwell | 2010-07-28 13:24:59 -0500 (Wed, 28 Jul 2010) | 23 lines

Merged revisions 280195 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r280195 | qwell | 2010-07-28 13:24:29 -0500 (Wed, 28 Jul 2010) | 16
lines

  Merged revisions 280193 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2

  ........
    r280193 | qwell | 2010-07-28 13:05:54 -0500 (Wed, 28 Jul 2010) | 9
lines

    Remove unnecessary subshells.  Attempt to make checksumming work.

    Also improves readability.

    (issue https://issues.asterisk.org/view.php?id=17621)
    Reported by: bjm

    Review: https://reviewboard.asterisk.org/r/808/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=280196 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-28 13:24 svnbot         Checkin                                      
2010-07-28 13:24 svnbot         Note Added: 0125208                          
======================================================================