[asterisk-bugs] [Asterisk 0017700]: [patch] When matching peers check invite from domain against domain list

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17700 
====================================================================== 
Reported By:                rsw686
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17700
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            N/A
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.11-rc1 
JIRA:                       SWP-1943 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-07-24 21:29 CDT
Last Modified:              2010-07-28 09:00 CDT
====================================================================== 
Summary:                    [patch] When matching peers check invite from domain
against domain list
Description: 
In trying to get the Exchange UM play on phone feature to work I developed
this patch. Exchange UM is sending the below SIP invite. Asterisk ignores
the domain when finding a matching SIP peer based on username. Since the
invite from field matches a device in sip.conf with a secret Asterisk is
responding with unauthorized. What I needed was for Asterisk to IP match my
sip peer with insecure=port,invite.

INVITE sip:2001 at voip.mydomain.net;user=phone SIP/2.0
FROM:
""<sip:2001 at exch.testdev.local;user=phone>;epid=079E8F8013;tag=849256682
TO: <sip:2001 at voip.mydomain.net;user=phone>

The debug output looks like 

Using INVITE request as basis request -
5c97e0f0-5456-4b82-a7f4-e7f2adeba338
Found peer '2001' for '2001' from 10.10.1.31:19219

The patch address the issue by checking the from domain when domain
support is enabled. In my configuration I just needed to enable
autodomain=yes in sip.conf.

Now the debug output looks like

Using INVITE request as basis request -
54d10d2e-01d1-451e-b21a-ef4bba987a0f
Unknown peer from domain exch.testdev.local
Found peer 'exchange-vm' for '2001' from 10.10.1.31:37810

For those not utilizing domain support this will have no effect. In my
testing with Polycom and Linksys phones all setup the invite with From:
userid at registrationserver. 
====================================================================== 

---------------------------------------------------------------------- 
 (0125190) rsw686 (reporter) - 2010-07-28 09:00
 https://issues.asterisk.org/view.php?id=17700#c125190 
---------------------------------------------------------------------- 
If I only match on IP I potentially have problems if somebody has two
phones at a remote location behind NAT. That is why I thought matching the
INVITE From: username based on domain namespace could be beneficial. The
domain support in Asterisk can restrict REGISTER and direct INIVTE's to a
context based on the To domain. Does it not make sense to add this
functionality?

My original patch was based on the thought of why would you want to match
a type=user object for a domain not defined on the Asterisk box. If I
changed it so that each type=user object could have a domain defined then
you potentially could have a multi-tenant system with the same username for
multiple domains. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-28 09:00 rsw686         Note Added: 0125190                          
======================================================================