[asterisk-bugs] [Asterisk 0017661]: [patch] redirecting to IPv6 URIs

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17661 
====================================================================== 
Reported By:                oej
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17661
Category:                   Channels/chan_sip/IPv6
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-1862 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 277027 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-16 07:26 CDT
Last Modified:              2010-07-27 13:54 CDT
====================================================================== 
Summary:                    [patch] redirecting to IPv6 URIs
Description: 
static int sip_sipredirect(struct sip_pvt *p, const char *dest){       
char *cdest;        char *extension, *host, *port;        char tmp[80];

        cdest = ast_strdupa(dest);

        extension = strsep(&cdest, "@");
        host = strsep(&cdest, ":");
        port = strsep(&cdest, ":");


This code will not be able to parse a
sip:lattjolajban@[fdd8:899a:a995:32dc:225:4bff:fea8:1d88]:5032 URI.
====================================================================== 

---------------------------------------------------------------------- 
 (0125137) svnbot (reporter) - 2010-07-27 13:54
 https://issues.asterisk.org/view.php?id=17661#c125137 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 279887

U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r279887 | mmichelson | 2010-07-27 13:54:06 -0500 (Tue, 27 Jul 2010) | 16
lines

Fix parsing error in sip_sipredirect().

The code was written in a way that did a bad job of
parsing the port out of a URI. Specifically, it would
do badly when dealing with an IPv6 address. In this
particular scenario, there was no value from parsing
the port out, so I just removed that logic. And while
I was messing around in the function, I changed some
variable names to be more descriptive.

(closes issue https://issues.asterisk.org/view.php?id=17661)
Reported by: oej
Patches: 
      17661.diff uploaded by mmichelson (license 60)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279887 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-27 13:54 svnbot         Checkin                                      
2010-07-27 13:54 svnbot         Note Added: 0125137                          
======================================================================