[asterisk-bugs] [Asterisk 0016705]: [patch] [regression] T.38 negotiation Broken

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16705 
====================================================================== 
Reported By:                mpiazzatnetbug
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16705
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-808 
Regression:                 Yes 
Reviewboard Link:           https://reviewboard.asterisk.org/r/754/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-26 08:42 CST
Last Modified:              2010-07-19 15:56 CDT
====================================================================== 
Summary:                    [patch] [regression] T.38 negotiation Broken
Description: 
After upgrading from 1.4.26.3 to 1.4.29 the T.38 negoation seems broken.
Probably this issue is a replication of 0016318 . Unfortunatly on the
1.4.29 it's look like the issue it's not totally fixed. 
I try to send a fax from an ATA to a fan on analog line.
ATA -> Asterisk -> Patton SN4091

When the fax answer the asterisk don't handle properly the call, on the
CLI I can see the message "Start music on hold" link with the ATA sip
channel.

As attachment the log of the console
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016318 [patch] New SDP handling code totally b...
has duplicate       0016852 [patch] Some issues with New SDP handli...
related to          0017014 Can't receive Fax with Patton 4554 ISDN...
====================================================================== 

---------------------------------------------------------------------- 
 (0124728) svnbot (reporter) - 2010-07-19 15:56
 https://issues.asterisk.org/view.php?id=16705#c124728 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 277944

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r277944 | pabelanger | 2010-07-19 15:56:05 -0500 (Mon, 19 Jul 2010) | 16
lines

Regression with T.38 negotiation

Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
of the reporter.  

(issue https://issues.asterisk.org/view.php?id=16852)
Reported by: cfc

(closes issue https://issues.asterisk.org/view.php?id=16705)
Reported by: mpiazzatnetbug
Patches:
      issue16705_2.diff uploaded by ebroad (license 878)
Tested by: vrban, ebroad, c0rnoTa, samdell3

Review: https://reviewboard.asterisk.org/r/754/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277944 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-19 15:56 svnbot         Checkin                                      
2010-07-19 15:56 svnbot         Note Added: 0124728                          
======================================================================