[asterisk-bugs] [Asterisk 0017665]: [patch] Regression: Externip has port set to 0

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17665 
====================================================================== 
Reported By:                mmichelson
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17665
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 276530 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-16 14:28 CDT
Last Modified:              2010-07-19 12:16 CDT
====================================================================== 
Summary:                    [patch] Regression: Externip has port set to 0
Description: 
It appears that the IPv6 merge has introduced an error in
ast_sip_ouraddrfor() such that the externip does not properly have its port
set.
====================================================================== 

---------------------------------------------------------------------- 
 (0124720) svnbot (reporter) - 2010-07-19 12:16
 https://issues.asterisk.org/view.php?id=17665#c124720 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 277873

U   trunk/channels/chan_sip.c
U   trunk/channels/sip/include/sip.h
U   trunk/configs/sip.conf.sample

------------------------------------------------------------------------
r277873 | mmichelson | 2010-07-19 12:16:22 -0500 (Mon, 19 Jul 2010) | 24
lines

Fix port setting of external address in SIP.

There are two changes here:

1. Since the externip setting can now have a port attached
to it, calling it "externip" is misleading. The option is now
documented and parsed as "externaddr." This also extends to the
"matchexterniplocally" setting. It is now documented and parsed
as "matchexternaddrlocally." The old names for the options may
still be used, but they are no longer used in the sip.conf.sample
file.

2. If no port is set for the externaddr, and UDP is the transport
to be used, then we will set the port of the externaddr to that of
the udpbindaddr. This was how things worked prior to the IPv6 merge,
so this is a regression fix.

(closes issue https://issues.asterisk.org/view.php?id=17665)
Reported by: mmichelson
Patches: 
      17665.diff#2 uploaded by pprindeville (license 347)
Tested by: pprindeville


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277873 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-19 12:16 svnbot         Checkin                                      
2010-07-19 12:16 svnbot         Note Added: 0124720                          
======================================================================