[asterisk-bugs] [Asterisk 0017498]: [patch] Bug in reporting queue hold time

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17498 
====================================================================== 
Reported By:                corruptor
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   17498
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.11
Asterisk Version:           SVN 
JIRA:                       SWP-1712 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-06-11 03:52 CDT
Last Modified:              2010-07-16 16:16 CDT
====================================================================== 
Summary:                    [patch] Bug in reporting queue hold time
Description: 
I've noticed that asterisk incorrectly reports estimate hold time to
callers if the hold time between more than 1 minute and less then 2
minutes.
Asterisk correctly calculates avg minutes and avg seconds but play
incorrect time.
Example:
-- Hold time for 6 is 1 minute(s) 30 seconds    -- <SIP/1110-000000a8>
Playing 'queue-holdtime.slin' (language 'ru')
    -- Nobody picked up in 10000 ms
    -- Stopped music on hold on SIP/1108-000000a6
    -- <SIP/1108-000000a6> Playing 'queue-youarenext.slin' (language
'ru')
    -- <SIP/1110-000000a8> Playing 'digits/1.slin' (language 'ru')
    -- <SIP/1110-000000a8> Playing 'queue-minute.slin' (language 'ru')
    -- <SIP/1110-000000a8> Playing 'digits/90.slin' (language 'ru')
    -- <SIP/1110-000000a8> Playing 'queue-seconds.slin' (language 'ru')

We hear 1 minute 90 seconds which is wrong
====================================================================== 

---------------------------------------------------------------------- 
 (0124658) svnbot (reporter) - 2010-07-16 16:16
 https://issues.asterisk.org/view.php?id=17498#c124658 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 277489

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r277489 | jpeeler | 2010-07-16 16:16:50 -0500 (Fri, 16 Jul 2010) | 17
lines

Merged revisions 277488 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r277488 | jpeeler | 2010-07-16 16:16:08 -0500 (Fri, 16 Jul 2010) | 10
lines
  
  Fix reporting estimated queue hold time.
  
  Just say the number of seconds (after minutes) rather than doing some
incorrect
  calculation with respect to minutes.
  
  (closes issue https://issues.asterisk.org/view.php?id=17498)
  Reported by: corruptor
  Patches: 
        holdesecs_bug.diff uploaded by corruptor (license 253)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277489 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-16 16:16 svnbot         Checkin                                      
2010-07-16 16:16 svnbot         Note Added: 0124658                          
======================================================================