[asterisk-bugs] [Asterisk 0017665]: [patch] Regression: Externip has port set to 0

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17665 
====================================================================== 
Reported By:                mmichelson
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17665
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 276530 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-16 14:28 CDT
Last Modified:              2010-07-16 14:56 CDT
====================================================================== 
Summary:                    [patch] Regression: Externip has port set to 0
Description: 
It appears that the IPv6 merge has introduced an error in
ast_sip_ouraddrfor() such that the externip does not properly have its port
set.
====================================================================== 

---------------------------------------------------------------------- 
 (0124647) mmichelson (administrator) - 2010-07-16 14:56
 https://issues.asterisk.org/view.php?id=17665#c124647 
---------------------------------------------------------------------- 
I have uploaded 17665.diff to the issue. It has two main changes.

1. Since externip can have a port specified, the name of the option is a
misnomer. All documentation has been adjusted to call it "externaddr"
instead. This also extends to the "matchexterniplocally" option. The old
names will still be accepted by the configuration parser, but they are no
longer documented.

2. ast_sip_ouraddrfor() has been updated so that if using UDP and the
externaddr has no port set, we use the port from bindaddr instead. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-16 14:56 mmichelson     Note Added: 0124647                          
2010-07-16 14:56 mmichelson     Status                   assigned => ready for
testing
======================================================================