[asterisk-bugs] [Asterisk 0017661]: [patch] redirecting to IPv6 URIs

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17661 
====================================================================== 
Reported By:                oej
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17661
Category:                   Channels/chan_sip/IPv6
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-1862 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 277027 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-16 07:26 CDT
Last Modified:              2010-07-16 12:45 CDT
====================================================================== 
Summary:                    [patch] redirecting to IPv6 URIs
Description: 
static int sip_sipredirect(struct sip_pvt *p, const char *dest){       
char *cdest;        char *extension, *host, *port;        char tmp[80];

        cdest = ast_strdupa(dest);

        extension = strsep(&cdest, "@");
        host = strsep(&cdest, ":");
        port = strsep(&cdest, ":");


This code will not be able to parse a
sip:lattjolajban@[fdd8:899a:a995:32dc:225:4bff:fea8:1d88]:5032 URI.
====================================================================== 

---------------------------------------------------------------------- 
 (0124624) mmichelson (administrator) - 2010-07-16 12:45
 https://issues.asterisk.org/view.php?id=17661#c124624 
---------------------------------------------------------------------- 
I've uploaded 17661.diff to the issue.

In this case, I noticed that there was no special handling for the port
and so it was pointless to be parsing it out at all. I also took the
opportunity to rename "tmp" and "localtmp" to more descriptive names.

Let me know if you see any potential problems with the change. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-16 12:45 mmichelson     Note Added: 0124624                          
2010-07-16 12:45 mmichelson     Status                   assigned => ready for
testing
======================================================================