[asterisk-bugs] [Asterisk 0017621]: [patch] sounds/Makefile ignores checksum errors

[Asterisk Bug Tracker]

The following issue is now READY FOR REVIEW. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17621 
====================================================================== 
Reported By:                bjm
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17621
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 275549 
Request Review:              
====================================================================== 
Date Submitted:             2010-07-11 19:07 CDT
Last Modified:              2010-07-12 11:02 CDT
====================================================================== 
Summary:                    [patch] sounds/Makefile ignores checksum errors
Description: 
While installing 1.6.2-SVN on OpenBSD 4.7, I got the disconcerting message
"/bin/sh: sha1sum: not found", yet the install continued.  The sha1sum
issue seems to be fixed in trunk,  but sounds/Makefile still ignores
errors. It emits the "Bad checksum:" message and exits 1, but inside a
subshell whose exit status is ignored.  So a symlink to the bad file is
created in sounds/, and a 0 status is returned to make, letting the install
continue with a dubious file in SOUNDS_CACHE_DIR.
====================================================================== 

---------------------------------------------------------------------- 
 (0124502) lmadsen (administrator) - 2010-07-12 11:02
 https://issues.asterisk.org/view.php?id=17621#c124502 
---------------------------------------------------------------------- 
Oh and there is a patch! Thanks! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-12 11:02 lmadsen        Note Added: 0124502                          
2010-07-12 11:02 lmadsen        Status                   acknowledged => ready
for review
======================================================================