[asterisk-bugs] [Asterisk 0017614]: [patch] IPv6 - Potential issue in via header parsing

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17614 
====================================================================== 
Reported By:                oej
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17614
Category:                   Channels/chan_sip/General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-1834 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 274865 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-07-09 07:47 CDT
Last Modified:              2010-07-09 14:47 CDT
====================================================================== 
Summary:                    [patch] IPv6 - Potential issue in via header parsing
Description: 
14223                 c = ast_skip_blanks(c+1);
14224                 if (strcasecmp(via, "SIP/2.0/UDP") &&
strcasecmp(via, "SIP/2.0/TCP") && strcasecmp(via, "SIP/2.0/TLS")) {
14225                         ast_log(LOG_WARNING, "Don't know how to
respond via '%s'\n", via);
14226                         return;
14227                 }
14228                 pt = strchr(c, ':');


Seems like we're looking for the first colon.

Via: SIP/2.0/TCP
[2620:0:2ef0:7070:250:60ff:fe03:32b7]:5060;branch=z9hG4bK4882ebf2298267bc4ba97d222289760c.1;rport


In this case, port would propably be 0 and not 5060...

====================================================================== 

---------------------------------------------------------------------- 
 (0124433) svnbot (reporter) - 2010-07-09 14:47
 https://issues.asterisk.org/view.php?id=17614#c124433 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 275308

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r275308 | mmichelson | 2010-07-09 14:46:20 -0500 (Fri, 09 Jul 2010) | 12
lines

Fix port parsing in check_via.

If a Via header contained an IPv6 address, we would not properly parse
the port. We would instead get the information after the first colon in
the address.

(closes issue https://issues.asterisk.org/view.php?id=17614)
Reported by: oej
Patches: 
      diff uploaded by sperreault (license 252)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=275308 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-09 14:47 svnbot         Checkin                                      
2010-07-09 14:47 svnbot         Note Added: 0124433                          
======================================================================