[asterisk-bugs] [Asterisk 0017536]: [patch] unload mod is not complete

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17536 
====================================================================== 
Reported By:                junky
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17536
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.4.33 
JIRA:                       SWP-1815 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 271517 
Request Review:              
====================================================================== 
Date Submitted:             2010-06-20 10:25 CDT
Last Modified:              2010-07-09 14:36 CDT
====================================================================== 
Summary:                    [patch] unload mod is not complete
Description: 
In the CLI,
if you type:
*CLI> unload chan_<tab>
chan_agent.so  chan_iax2.so   chan_mgcp.so   chan_sip.so    
*CLI> module unload chan<tab>
chan_agent.so   chan_iax2.so    chan_local.so   chan_mgcp.so   
chan_oss.so     chan_phone.so   chan_sip.so     chan_skinny.so  
*CLI> module unload chan_

the unload (which is deprecated in 1.4) should contains the same list as
module unload, when you hit Tab.
Not a big deal, since that command disapeared in 1.6.x, but still a small
bug in 1.4.

The reason why, it's because the unload is calling the list with the
needs_reload, which means, if a module is not possible to reload, it won't
be tab-completed.
====================================================================== 

---------------------------------------------------------------------- 
 (0124430) svnbot (reporter) - 2010-07-09 14:36
 https://issues.asterisk.org/view.php?id=17536#c124430 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 275290

U   branches/1.4/main/cli.c

------------------------------------------------------------------------
r275290 | pabelanger | 2010-07-09 14:28:48 -0500 (Fri, 09 Jul 2010) | 8
lines

fix tab-completion for unload command.

(closes issue https://issues.asterisk.org/view.php?id=17536)
Reported by: junky
Patches:
      unload_vs_mod_unload.diff uploaded by junky (license 177)
Tested by: pabelanger

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=275290 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-09 14:36 svnbot         Checkin                                      
2010-07-09 14:36 svnbot         Note Added: 0124430                          
======================================================================