[asterisk-bugs] [Asterisk 0017598]: AGI manager command is not consistent with other commands

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17598 
====================================================================== 
Reported By:                rrb3942
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17598
Category:                   Resources/res_agi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-07-07 09:37 CDT
Last Modified:              2010-07-07 12:16 CDT
====================================================================== 
Summary:                    AGI manager command is not consistent with other
commands
Description: 
There are a few issues with the AGI manager command.

1. Does not appear to use ActionIDs at all (Very Bad).
2. Uses a CommandID, but this is only used in some of it's response
events. This should be replaced with the ActionID used with the command.
3. The message or response line in the initial acknowledgement should
should indicate that the results will follow.
4. Response Events require you to have 'agi' events enabled in order to
receive them. They are also sent to everyone listening to those events.
This could cause CommandID/ActionID collision.
5. The command should end with a 'Complete' event.
====================================================================== 

---------------------------------------------------------------------- 
 (0124313) rrb3942 (reporter) - 2010-07-07 12:16
 https://issues.asterisk.org/view.php?id=17598#c124313 
---------------------------------------------------------------------- 
The complete lack of the use of ActionIDs seems like a bug to me. This
command is different enough that it can cause compatibility issues with
some of the libraries used for working with the AMI if the author does not
make serious exceptions to handle it.

I can do some work on a patch for this. I just have not done any work
towards it 

If you like I could also break this up into two patches.

Patch 1 - Add ActionIDS and make it and the CommandID present throughout
all response. Change responses to only be sent back on the appropriate
manager connection without the need to have events enabled. I don't think
is would break compatibility.

Patch 2 - Rest of it, making it more consistent with other commands. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-07 12:16 rrb3942        Note Added: 0124313                          
======================================================================