[asterisk-bugs] [Asterisk 0016102]: [patch] default say.conf for new number method doesnt handle all numbers

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16102 
====================================================================== 
Reported By:                Delvar
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16102
Category:                   Applications/app_playback
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.1.6 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-20 09:11 CDT
Last Modified:              2010-07-06 21:36 CDT
====================================================================== 
Summary:                    [patch] default say.conf for new number method
doesnt handle all numbers
Description: 
the [en-base] in say.conf by default doesnt work very well when dealing
with numbers like 100,100,100 (one hundred million one hundred thousand one
hundred)

firstly it actualt says,
one hundred million zerro one hundred thousand zerro one hundred zerro
secondly its missing the 'and'

one hundred million one hundred thousand /and/ one hundred

anyway i spent an hour or so writing a new say.conf, ill upload it here
along with a test dialplan to show it working.
====================================================================== 

---------------------------------------------------------------------- 
 (0124282) elguero (reporter) - 2010-07-06 21:36
 https://issues.asterisk.org/view.php?id=16102#c124282 
---------------------------------------------------------------------- 
The patch to fix the en-base for 100 and 1000 is working properly.

The patch adding en_GB works too.  

Just a thought though.  If someone wants to use en_GB as the language,
wouldn't they normally have sound files for en_GB?  In looking at say.c, it
handles the "and" properly.  The base en sounds do not have the sound file
"digit/and".  The en_GB section would only be needed if someone wanted to
follow the en_GB way of pronouncing numbers with the core en sound files.

In looking at how other languages are handled, it would appear they all
have a "digit/and" sound file.  That is why say.c is programmed to look for
"digit/and" under the languages sound directory.  It would make better
sense to me to follow the same structure for uniformity sake.  With that
said, a simple "cp /var/lib/asterisk/sounds/en/vm-and.gsm
/var/lib/asterisk/sounds/en/digit/and.gsm" would accomplish this as well
without the need to use say.conf.  Just my thoughts on this.  Perhaps, we
should add some documentation to explain why the en_GB section was added. 
Could help show the flexibility that is present by using say.conf? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-06 21:36 elguero        Note Added: 0124282                          
======================================================================