[asterisk-bugs] [Asterisk 0017576]: [patch] Cannot join a queue when all members are paused and "joinempty=no".

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17576 
====================================================================== 
Reported By:                ramonpeek
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17576
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.33 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-07-01 09:08 CDT
Last Modified:              2010-07-02 02:57 CDT
====================================================================== 
Summary:                    [patch] Cannot join a queue when all members are
paused and "joinempty=no".
Description: 
It's not possible to join a queue when all members are paused and
"joinempty" is set to no.

Pausing all members in a queue means the queue still has members, but they
are not reachable. Which means that if "joinempty=no" is set, the queue
should except callers. Only if "joinempty=strict" is set, should the call
not be accepted.
====================================================================== 

---------------------------------------------------------------------- 
 (0124176) ramonpeek (reporter) - 2010-07-02 02:57
 https://issues.asterisk.org/view.php?id=17576#c124176 
---------------------------------------------------------------------- 
That issue (https://issues.asterisk.org/view.php?id=12451) was closed with the
argument that there is nothing
wrong with the code.
I would like to argue that comment.
The documentation for the setting "joinempty" says:

; yes    - callers can join a queue with no members or only unavailable
members
; no     - callers cannot join a queue with no members
; strict - callers cannot join a queue with no members or only
unavailable
;          members

Which means callers should be able to Join a queue when the setting
"joinempty=no" is set and members are assign to a queue but are paused.
This is currently NOT the case, if all members are logged out and/or
paused to queue is currently considered to have NO_MEMBERS, which is
incorrect.

I agree that the code has been changed quite a bit, especially for trunk
and also 1.6.2 versions. But the 1.4.33 version is a maintained version
that contains this "bug". I would think it wrong not the fix this in the
maintained version of 1.4.

Besides..., the change is minimal and doesn't introduce other weird
things.
Except for those users that are now taking "advantage" of the bug and
might get confused after this fix. To them I would say "use
joinempty=strict" 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-07-02 02:57 ramonpeek      Note Added: 0124176                          
======================================================================