[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1-beta4 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2010-01-26 11:20 CST
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0117201) dvossel (administrator) - 2010-01-26 11:20
 https://issues.asterisk.org/view.php?id=14331#c117201 
---------------------------------------------------------------------- 
If r->hostname is peer_1, peer_1's host and fromdomain along with other
peer data is copied into the dialog in create_addr_from_peer (which is
called within create_addr() in transmit_register())

If the fromdomain is set for the dialog, that is used as the host addr in
transmit_register.  I'm not saying whether this is correct or not, but this
is behavior that has been around for quite some time.  It broke some
configs, so I was asked to restore the previous behavior. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-26 11:20 dvossel        Note Added: 0117201                          
======================================================================