[asterisk-bugs] [Asterisk 0015008]: [patch] Introduce better parsing for the register line

Fri Jan 22 18:42:15 CST 2010

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15008 
====================================================================== 
Reported By:                tilghman
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15008
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.0
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 191365 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-04-30 17:12 CDT
Last Modified:              2010-01-22 18:42 CST
====================================================================== 
Summary:                    [patch] Introduce better parsing for the register
line
Description: 
People have asked for the ability to use characters that are otherwise used
as delimiters in the register line, such as '/', '@', and ':'.  In the
past, we've had to say no, because the register line is very simply
parsed.

This patch allows any part of the register line to be quoted, and the
section within the quote may contain any of these special characters. 
Literal quotes and literal backslashes may be added to these fields by
prefixing them with a backslash.  Also, if no quotes are used around a
particular field, the delimiter character may be preceded with a backslash,
to encode that literal character within the field.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015672 ? in register= string breaks registration
====================================================================== 

---------------------------------------------------------------------- 
 (0117101) svnbot (reporter) - 2010-01-22 18:42
 https://issues.asterisk.org/view.php?id=15008#c117101 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 242514

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c
U   branches/1.6.0/configs/sip.conf.sample

------------------------------------------------------------------------
r242514 | tilghman | 2010-01-22 18:42:09 -0600 (Fri, 22 Jan 2010) | 55
lines

Backporting register line parsing from trunk to fix a bad parsing error in
1.6.0.

(closes issue https://issues.asterisk.org/view.php?id=16491)
 Reported by: jamicque
 Patches: 
       20100114__issue16491.diff.txt uploaded by tilghman (license 14)
 Tested by: jamicque

........
  r213098 | tilghman | 2009-08-19 16:05:17 -0500 (Wed, 19 Aug 2009) | 9
lines

  Better parsing for the "register" line
  Allows characters that are otherwise used as delimiters to be used
within
  certain fields (like the secret).
  (closes issue https://issues.asterisk.org/view.php?id=15008, closes issue
https://issues.asterisk.org/view.php?id=15672)
   Reported by: tilghman
   Patches: 
         20090818__issue15008.diff.txt uploaded by tilghman (license 14)
   Tested by: lmadsen, tilghman
........
  r213635 | dvossel | 2009-08-21 16:02:50 -0500 (Fri, 21 Aug 2009) | 5
lines

  fixes sip register parsing when user at domain is used

  (issue https://issues.asterisk.org/view.php?id=15008)
  (issue https://issues.asterisk.org/view.php?id=15672)
........
  r215222 | tilghman | 2009-09-01 16:19:40 -0500 (Tue, 01 Sep 2009) | 3
lines

  Fix register such that lines with a transport string, but without an
authuser, parse correctly.
  (AST-228)
........
  r215801 | tilghman | 2009-09-02 22:43:51 -0500 (Wed, 02 Sep 2009) | 5
lines

  Default the callback extension to "s".  This is a regression.
  (closes issue https://issues.asterisk.org/view.php?id=15764)
   Reported by: elguero
   Change-type: bugfix
........
  r235132 | dvossel | 2009-12-15 12:43:06 -0600 (Tue, 15 Dec 2009) | 14
lines

  reverse minor sip registration regression

  A registration regression caused by a code tweak in (issue
https://issues.asterisk.org/view.php?id=14331)
  and a bug fix in (issue https://issues.asterisk.org/view.php?id=15539) caused
some sip registration
  config entries to be constructed incorrectly.  Origially
  issue https://issues.asterisk.org/view.php?id=14331 contained the code tweak
as well as a bug fix, but since
  the issue was reported as a tweak the bug fix portion was moved into
  issue https://issues.asterisk.org/view.php?id=15539.  Both the tweak and the
bug fix contained minor incorrect
  logic that resulted in some SIP registrations to fail.

  (issue https://issues.asterisk.org/view.php?id=14331)
  (issue https://issues.asterisk.org/view.php?id=15539)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=242514 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-22 18:42 svnbot         Checkin                                      
2010-01-22 18:42 svnbot         Note Added: 0117101                          
======================================================================