[asterisk-bugs] [Asterisk 0014629]: [patch] Add support in AEL for macro return values and direct assignment of them to variables and functions.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14629 
====================================================================== 
Reported By:                Marquis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14629
Category:                   PBX/pbx_ael
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-282 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-09 06:03 CDT
Last Modified:              2010-01-22 16:02 CST
====================================================================== 
Summary:                    [patch] Add support in AEL for macro return values
and direct assignment of them to variables and functions.
Description: 
This patch adds macro return value and simple assignment support to AEL.

This is the bug report for review request 114 as per Russell Bryant.
http://reviewboard.digium.com/r/114/
====================================================================== 

---------------------------------------------------------------------- 
 (0117089) tilghman (administrator) - 2010-01-22 16:02
 https://issues.asterisk.org/view.php?id=14629#c117089 
---------------------------------------------------------------------- 
I concur.  This is not quite ready yet.

[Jan 22 15:59:06] NOTICE[8639]: pbx_ael.c:122 pbx_load_module: Starting
AEL load process.
[Jan 22 15:59:06] ERROR[8639]: ael.y:836 ael_yyerror: ==== File:
/etc/asterisk/extensions.ael, Line 326, Cols: 21-25: Error: syntax error,
unexpected word, expecting ';'
[Jan 22 15:59:06] ERROR[8639]: ael.y:836 ael_yyerror: ==== File:
/etc/asterisk/extensions.ael, Line 343, Cols: 8-8: Error: syntax error,
unexpected '}'
[Jan 22 15:59:06] NOTICE[8639]: pbx_ael.c:135 pbx_load_module: AEL load
process: parsed config file name '/etc/asterisk/extensions.ael'.
[Jan 22 15:59:06] WARNING[8639]: ael/pval.c:707 check_macro_returns:
Warning: file /etc/asterisk/extensions.ael, line 324-342: The macro
ael_sample does not end with a return; I will insert one.
[Jan 22 15:59:06] WARNING[8639]: ael/pval.c:859 check_includes: Warning:
file /etc/asterisk/extensions.ael, line 392-394: The included context
'ael-demo' cannot be found.
 (You may ignore this warning if 'ael-demo' exists in extensions.conf, or
is created by another module. I cannot check for those.)
[Jan 22 15:59:06] ERROR[8639]: pbx_ael.c:151 pbx_load_module: Sorry, but 2
syntax errors and 0 semantic errors were detected. It doesn't make sense to
compile.

with:

macro ael_sample() {
    NoOp;
    return "foo bar";
};

context ael-demo {
    s => {
        Wait(1);
        Answer();
        Set(foo=&ael_sample());
        Set(TIMEOUT(digit)=5);
        Set(TIMEOUT(response)=10);
restart:
        Background(demo-congrats);
instructions:
        for (x=0; ${x} < 3; x=${x} + 1) {
            Background(demo-instruct);
            WaitExten();
        };
    };
... 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-22 16:02 tilghman       Note Added: 0117089                          
======================================================================