[asterisk-bugs] [Asterisk 0016471]: [patch] calling ConfBridge() with no timing source causes segfault

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16471 
====================================================================== 
Reported By:                kjotte
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16471
Category:                   Applications/app_confbridge
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     ready for review
Asterisk Version:           Addons-1.6.2.0 
JIRA:                       SWP-684 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-12-19 10:38 CST
Last Modified:              2010-01-21 18:22 CST
====================================================================== 
Summary:                    [patch] calling ConfBridge() with no timing source
causes segfault
Description: 
Calling ConfBridge() with no res_timing_* module loaded causes a
segmentation fault and brings down the whole PBX.  Perhaps some check for a
valid timing source needs to be made on the way in and drop the call if
none exists?
====================================================================== 

---------------------------------------------------------------------- 
 (0117048) srt (reporter) - 2010-01-21 18:22
 https://issues.asterisk.org/view.php?id=16471#c117048 
---------------------------------------------------------------------- 
There are more places where bridge->bridge_pvt is accessed without a proper
check which cause additional segfaults.

Example:
In line 275 of bridge/bridge_softmix.c I had to replace
ast_timer_ack(timer, 1); by

if (bridge->bridge_pvt) {
  ast_timer_ack(timer, 1);
} 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-21 18:22 srt            Note Added: 0117048                          
======================================================================