[asterisk-bugs] [Asterisk 0014629]: [patch] Add support in AEL for macro return values and direct assignment of them to variables and functions.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14629 
====================================================================== 
Reported By:                Marquis
Assigned To:                dbrooks
====================================================================== 
Project:                    Asterisk
Issue ID:                   14629
Category:                   PBX/pbx_ael
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-282 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-09 06:03 CDT
Last Modified:              2010-01-21 08:38 CST
====================================================================== 
Summary:                    [patch] Add support in AEL for macro return values
and direct assignment of them to variables and functions.
Description: 
This patch adds macro return value and simple assignment support to AEL.

This is the bug report for review request 114 as per Russell Bryant.
http://reviewboard.digium.com/r/114/
====================================================================== 

---------------------------------------------------------------------- 
 (0117016) crjw (reporter) - 2010-01-21 08:38
 https://issues.asterisk.org/view.php?id=14629#c117016 
---------------------------------------------------------------------- 
I tried to use this patch for the first time yesterday.
I was trying it with with the latest trunk code (version:241714M).

When I attempt to pass an argument to "return", the parser reports a
syntax error.

e.g.:
With this macro (as copied from the CHANGES file):
    macro returnmacro() {
        MYVAR=10;
        return ${MYVAR};
    }
I get the error:
ERROR[10825]: ael.y:840 ael_yyerror: ==== File:
/apps/asterisk/etc/extensions.ael, Line 71, Cols: 16-24: Error: syntax
error, unexpected word, expecting ';'

I am running this on Solaris SXCE 129.  But I doubt the OS should make
much of a difference.

In the last posting by Marquis' on nov 23/2009, there is mention of
regenerating the lexer and parser.  Is this something that everybody
applying the patch is supposed to do? And if so, how is this done?
In my testing I simply downloaded the latest trunk into an brand new
directory, applied the patch, compiled, and installed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-21 08:38 crjw           Note Added: 0117016                          
======================================================================