[asterisk-bugs] [Asterisk 0016586]: [patch] features.conf auto-included park function sometimes included junk in Park() command

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16586 
====================================================================== 
Reported By:                DLNoah
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   16586
Category:                   Applications/app_parkandannounce
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.0 
JIRA:                       SWP-707 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-01-12 09:20 CST
Last Modified:              2010-01-19 17:02 CST
====================================================================== 
Summary:                    [patch] features.conf auto-included park function
sometimes included junk in Park() command
Description: 
When using the included parking context from features.conf, or using an
Aastra phone with their built-in park softkey (which appears to call the
same built-in park, from what I can tell) in any version of 1.6.x that I've
used (including 1.6.0.9, 1.6.0.15, 1.6.1.0, 1.6.2.0), the Park() command
will sometimes but inconsistently include extra information--most commonly
a channel that was dialed by the parking phone.  In 1.6.0.x, the extra
information is simply ignored as Park() doesn't take parameters.  In
1.6.1.x and 1.6.2.x, Park interprets this information numerically (usually
as 0, since they generally start with a letter), which causes the call to
timeout immediately.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016406 Calls transfered to parking lot immedia...
====================================================================== 

---------------------------------------------------------------------- 
 (0116961) svnbot (reporter) - 2010-01-19 17:02
 https://issues.asterisk.org/view.php?id=16586#c116961 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 241369

_U  branches/1.6.2/
U   branches/1.6.2/main/pbx.c

------------------------------------------------------------------------
r241369 | jpeeler | 2010-01-19 17:02:22 -0600 (Tue, 19 Jan 2010) | 19
lines

Merged revisions 241366 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r241366 | jpeeler | 2010-01-19 16:59:53 -0600 (Tue, 19 Jan 2010) | 13
lines
  
  Initialize data on the stack so that Park doesn't interpret random
arguments.
  
  passdata was only being set in pbx_substitue_variables when arguments
were
  passed.
  
  (closes issue https://issues.asterisk.org/view.php?id=16406)
  (closes issue https://issues.asterisk.org/view.php?id=16586)
  Reported by: DLNoah
  Patches: 
        bug16586v2.patch uploaded by jpeeler (license 325)
  Tested by: DLNoah
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241369 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-19 17:02 svnbot         Checkin                                      
2010-01-19 17:02 svnbot         Note Added: 0116961                          
======================================================================