[asterisk-bugs] [Asterisk 0016489]: [patch] Missing plus signs in MAKE/SUBMAKE calls prevent parallel make from operating correctly

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16489 
====================================================================== 
Reported By:                Chainsaw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16489
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.1.14
Asterisk Version:           1.6.1.12 
JIRA:                       SWP-571 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-12-21 08:04 CST
Last Modified:              2010-01-19 07:25 CST
====================================================================== 
Summary:                    [patch] Missing plus signs in MAKE/SUBMAKE calls
prevent parallel make from operating correctly
Description: 
This patch applies to the 1.6.1.12 release tarball and hopefully also to
the 1.6.2 branch. Parallel make fixes were applied for the compilation
process, but not the installation process.
This patch addresses that.
====================================================================== 

---------------------------------------------------------------------- 
 (0116883) Chainsaw (reporter) - 2010-01-19 07:25
 https://issues.asterisk.org/view.php?id=16489#c116883 
---------------------------------------------------------------------- 
Please delete "V2" and stick to the 1.6.2.1 patch.
This fixes the operation when make is called with -jX, where X is higher
then 1. I use -j12 on my 12-core system at home for example.

If this patch is not applied, make will warn that it is defaulting to -j1
as it was not called correctly. The utilisation of cores on my system is
very low as a result, and the total compilation time goes up.
Any multi-core machine should show you the improvements.

Autotools upstream describes it like so:
warning: jobserver unavailable: using -j1. Add `+' to parent make rule.'
In order for make processes to communicate, the parent will pass
information to the child. Since this could result in problems if the child
process isn't actually a make, the parent will only do this if it thinks
the child is a make. The parent uses the normal algorithms to determine
this (see How the MAKE Variable Works). If the makefile is constructed such
that the parent doesn't know the child is a make process, then the child
will receive only part of the information necessary. In this case, the
child will generate this warning message and proceed with its build in a
sequential manner. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-19 07:25 Chainsaw       Note Added: 0116883                          
======================================================================