[asterisk-bugs] [Asterisk 0016006]: [patch] call time limit overflow

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16006 
====================================================================== 
Reported By:                viraptor
Assigned To:                mnick
====================================================================== 
Project:                    Asterisk
Issue ID:                   16006
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           Older 1.6.1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-01 11:21 CDT
Last Modified:              2010-01-18 16:31 CST
====================================================================== 
Summary:                    [patch] call time limit overflow
Description: 
Call limit specified with L option overflows without warning when the value
reaches 2^31. Call is disconnected without any specific message then.

So really there should be 2 fixes:
- Dial() should report that the call was stopped because of the timeout
- limit of 2^31 should be handled more properly
====================================================================== 

---------------------------------------------------------------------- 
 (0116858) svnbot (reporter) - 2010-01-18 16:31
 https://issues.asterisk.org/view.php?id=16006#c116858 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 241143

U   trunk/channels/chan_dahdi.c
U   trunk/channels/sig_analog.c
U   trunk/include/asterisk/time.h
U   trunk/main/channel.c
U   trunk/main/enum.c
U   trunk/main/features.c
U   trunk/main/timing.c
U   trunk/pbx/pbx_dundi.c

------------------------------------------------------------------------
r241143 | jpeeler | 2010-01-18 16:31:26 -0600 (Mon, 18 Jan 2010) | 13
lines

Extend max call limit duration from 24.8 days to 292+ million years.

If the limit was set past MAX_INT upon answering, the call was immediately
hung up due to overflow from the return of ast_tvdiff_ms (in
ast_check_hangup).
The time calculation functions ast_tvdiff_sec and ast_tvdiff_ms have been
changed to return an int64_t to prevent overflow. Also the reporter
suggested
adding a message indicating the reason for the call hanging up. Given that
the
new limit is so much higher, the message (which would only really be
useful in
the overflow scenario) has been made a debug message only.

(closes issue https://issues.asterisk.org/view.php?id=16006)
Reported by: viraptor

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=241143 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-18 16:31 svnbot         Note Added: 0116858                          
======================================================================