[asterisk-bugs] [Asterisk 0016271]: [patch] message limit (maxmsg) can be exceeded in 1.6.x creating orphan voicemail

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16271 
====================================================================== 
Reported By:                sohosys
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16271
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.22
Asterisk Version:           SVN 
JIRA:                       SWP-432 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-18 08:27 CST
Last Modified:              2010-01-15 14:56 CST
====================================================================== 
Summary:                    [patch] message limit (maxmsg) can be exceeded in
1.6.x creating orphan voicemail
Description: 
If two are more users are in the process of leaving a voicemail message,
and the count of messages in the mailbox was maxmsg-1 when they started
leaving the message, the application will record all new messages.

Messages will be numbered in the order they were completed, and all
messages over the limit will be inaccessible to the end user. We have
tested up to 5 callers in voicemail resulting in maxmsg+4 messages and 4
inaccessible messages. I assume there is no limit based on the code.

We run some high volume asterisk servers where this has become common. In
the 1.6 series the message is not reported and not accessible by the end
user, although the caller that left the last messages(s) had no indication
of the full mailbox.

I guess this could be classified as minor or major depending on the
content of the messages in the black hole and the job title of the mailbox
owner.

In the 1.2.x series a crash is the result when the end user tries to
access the last messages in the mailbox, and we fixed that by simply adding
10 to our desired maxmsg count in voicemail.conf and changing the code to
test for msgcount <= maxmsg - 10 before accepting a new message, but the
1.6 code is more complex, and our 1.2 solution is too primitive for a
current version, although transparently buffering the variables might be a
good simple solution.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015117 crash in voicemail when more than maxms...
====================================================================== 

---------------------------------------------------------------------- 
 (0116757) svnbot (reporter) - 2010-01-15 14:56
 https://issues.asterisk.org/view.php?id=16271#c116757 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 240416

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_voicemail.c

------------------------------------------------------------------------
r240416 | tilghman | 2010-01-15 14:56:33 -0600 (Fri, 15 Jan 2010) | 29
lines

Merged revisions 240415 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r240415 | tilghman | 2010-01-15 14:54:24 -0600 (Fri, 15 Jan 2010) | 22
lines
  
  Merged revisions 240414 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15
lines
    
    Disallow leaving more than maxmsg voicemails.
    This is a possibility because our previous method assumed that no
messages are
    left in parallel, which is not a safe assumption.  Due to the vmu
structure
    duplication, it was necessary to track in-process messages via a
separate
    structure.  If at some point, we switch vmu to an
ao2-reference-counted
    structure, which would eliminate the prior noted duplication of
structures,
    then we could incorporate this new in-process structure directly into
vmu.
    (closes issue https://issues.asterisk.org/view.php?id=16271)
     Reported by: sohosys
     Patches: 
           20100108__issue16271.diff.txt uploaded by tilghman (license 14)
           20100108__issue16271__trunk.diff.txt uploaded by tilghman
(license 14)
           20100108__issue16271__1.6.0.diff.txt uploaded by tilghman
(license 14)
     Tested by: jsutton
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=240416 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-15 14:56 svnbot         Checkin                                      
2010-01-15 14:56 svnbot         Note Added: 0116757                          
======================================================================