[asterisk-bugs] [Asterisk 0016601]: app_sms hangs on a call sending an sms

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16601 
====================================================================== 
Reported By:                madcowzz
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16601
Category:                   Applications/app_sms
Reproducibility:            sometimes
Severity:                   block
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.0 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-14 05:06 CST
Last Modified:              2010-01-14 06:16 CST
====================================================================== 
Summary:                    app_sms hangs on a call sending an sms
Description: 
I'm not sure it's a bug, I'm new to asterisk and I not found anything on
this.
Sending an sms to Telecom Italia smsc (4210) causes app_sms to send the
sms and then keeps the line busy waiting for something to happen.
I have modified apps_sms.c in the sms_process function commenting the 1734
line:

//		h->idle = 0;

This makes app_sms to send the sms and then drop the line because the idle
reaches the 80000 value.
Repeat: I'm not sure this is a bug and is more likely to have something
wrong with me.

====================================================================== 

---------------------------------------------------------------------- 
 (0116655) madcowzz (reporter) - 2010-01-14 06:16
 https://issues.asterisk.org/view.php?id=16601#c116655 
---------------------------------------------------------------------- 
Working on the code I discovered that the problem depends on the error bad
stop bit.
When the error occurs app_sms awaits a response from the server that never
comes.
Setting the hangup property of h to 1 when the error occurs the call is
properly closed immediately after that the message is sent.
So, on line 1799 I added:

					if (!bit) {             /* bad stop bit */
						ast_log(LOG_NOTICE, "bad stop bit");
                                                h->hangup = 1;
						h->ierr = 0xFF;     /* unknown error */

I restored the line 1734, of course. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-14 06:16 madcowzz       Note Added: 0116655                          
======================================================================