[asterisk-bugs] [DAHDI-tools 0016597]: [patch] Dadhi-tools ignores linker flags when building utilities in xpp/

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16597 
====================================================================== 
Reported By:                pprindeville
Assigned To:                
====================================================================== 
Project:                    DAHDI-tools
Issue ID:                   16597
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2010-01-13 18:36 CST
Last Modified:              2010-01-13 19:45 CST
====================================================================== 
Summary:                    [patch] Dadhi-tools ignores linker flags when
building utilities in xpp/
Description: 
The value of $(LDFLAGS) is not used by xpp/Makefile when doing terminal
link edit.

Example:

fpga_load: fpga_load.o hexfile.o
        $(CC) -L. -o $@ $^ $(EXTRA_LIBS) $(USB_LIB)

astribank_hexload: $(ABHEXLOAD_OBJS)
        $(CC) -L. -o $@ $(ABHEXLOAD_OBJS) $(EXTRA_LIBS) $(USB_LIB)

astribank_tool: $(ABTOOL_OBJS)
        $(CC) -L. -o $@ $(ABTOOL_OBJS) $(EXTRA_LIBS) $(USB_LIB)

astribank_allow: $(ABALLOW_OBJS)
        $(CC) -L. -o $@ $(ABALLOW_OBJS) $(EXTRA_LIBS) $(USB_LIB)

fpga_load.o: CFLAGS+=-D_GNU_SOURCE      # We use memrchr()

test_parse: test_parse.o hexfile.o
        $(CC) -L. -o $@ $^ $(EXTRA_LIBS) $(USB_LIB)


also, it's not clear that there's any value to using $(CC) to link instead
of $(LD).

====================================================================== 

---------------------------------------------------------------------- 
 (0116645) pprindeville (reporter) - 2010-01-13 19:45
 https://issues.asterisk.org/view.php?id=16597#c116645 
---------------------------------------------------------------------- 
Tested, and seems to work.

At least the traces of doing a "make" seem sane. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-13 19:45 pprindeville   Note Added: 0116645                          
======================================================================