[asterisk-bugs] [Asterisk 0015552]: [patch] SIP_BODY function to get a body part of a SIP message

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15552 
====================================================================== 
Reported By:                khw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15552
Category:                   Functions/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-410 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 206090 
Request Review:              
====================================================================== 
Date Submitted:             2009-07-22 05:10 CDT
Last Modified:              2010-01-13 04:06 CST
====================================================================== 
Summary:                    [patch] SIP_BODY function to get a body part of a
SIP message
Description: 
this patch adds the function SIP_BODY for chan_sip to get a body part by
its Content-Type. Therefore, the existing find_sdp() is generalized to
find_content() and find_sdp() calls find_content() with the parameter
"application/sdp". 

usage example: ${SIP_BODY(application/pidf+xml)} to get a PIDF document
from the SIP body.
====================================================================== 

---------------------------------------------------------------------- 
 (0116556) oej (manager) - 2010-01-13 04:06
 https://issues.asterisk.org/view.php?id=15552#c116556 
---------------------------------------------------------------------- 
There are still some coding issues I noticed:

 - No comments with //
 - Don't declare variables in the middle of a code block. (int size = )
 - if statements should always have brackets {} - even if it's a
one-liner

The coding guidelines are included in the doc/ directory.

Using ast_verbose for notices is not good. Maybe you should use
ast_log(LOG_WARNING instead

I think this is a great addition to asterisk! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-13 04:06 oej            Note Added: 0116556                          
======================================================================