[asterisk-bugs] [Asterisk 0016241]: [patch] issues in processing "Action: Events" eventmask

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16241 
====================================================================== 
Reported By:                vnovy
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16241
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.4.30
Asterisk Version:           SVN 
JIRA:                       SWP-589 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 227580 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-13 06:32 CST
Last Modified:              2010-01-08 19:27 CST
====================================================================== 
Summary:                    [patch] issues in processing "Action: Events"
eventmask
Description: 
1/ Incorrect check if eventmask is number in function strings_to_mask

2/ "Action: events" with "eventmask: on" returns no answer.
When "eventmask: on" all eventmask values in perms structure are ORed
including  "all" with value -1, so function strings_to_mask returns -1 as
current mask. This value is interpreted as error by action_events function
and no response is sent

3/ "Action: events" with "eventmask: all" returns no answer.
"all" is in list of valid eventmask values, but value -1 causes same
problem as in 2/ 
====================================================================== 

---------------------------------------------------------------------- 
 (0116404) svnbot (reporter) - 2010-01-08 19:27
 https://issues.asterisk.org/view.php?id=16241#c116404 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 238968

_U  branches/1.6.0/
U   branches/1.6.0/main/manager.c

------------------------------------------------------------------------
r238968 | tilghman | 2010-01-08 19:27:35 -0600 (Fri, 08 Jan 2010) | 20
lines

Merged revisions 238916 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r238916 | tilghman | 2010-01-08 19:08:04 -0600 (Fri, 08 Jan 2010) | 13
lines
  
  Merged revisions 238915 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r238915 | tilghman | 2010-01-08 18:57:58 -0600 (Fri, 08 Jan 2010) | 6
lines
    
    -1 is interpreted as an error, intead of the maximum mask.
    (closes issue https://issues.asterisk.org/view.php?id=16241)
     Reported by: vnovy
     Patches: 
           manager.c.patch uploaded by vnovy (license 922)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238968 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-08 19:27 svnbot         Note Added: 0116404                          
======================================================================