[asterisk-bugs] [Asterisk 0016522]: [regression] MixMonitor stops recording after transfer using AUDIOHOOK_INHERIT

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16522 
====================================================================== 
Reported By:                corruptor
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   16522
Category:                   Applications/app_mixmonitor
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Target Version:             1.6.0.22
Asterisk Version:           SVN 
JIRA:                       SWP-622 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 236714 
Request Review:              
====================================================================== 
Date Submitted:             2009-12-29 06:51 CST
Last Modified:              2010-01-08 13:39 CST
====================================================================== 
Summary:                    [regression] MixMonitor stops recording after
transfer using AUDIOHOOK_INHERIT
Description: 
We record calls using MixMonitor. Before dialing I use
Set(AUDIOHOOK_INHERIT(MixMonitor)=yes). Asterisk writes to log "MixMonitor
close filestream" only after Hangup which is ok but audio is not recorded
just after transfer (it doesn't metter asterisk transfer or SIP transfer).
This worked in 1.6.0.17.
I mark is as major because this is a regression.


====================================================================== 

---------------------------------------------------------------------- 
 (0116375) svnbot (reporter) - 2010-01-08 13:39
 https://issues.asterisk.org/view.php?id=16522#c116375 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 238635

U   trunk/include/asterisk/audiohook.h
U   trunk/main/audiohook.c

------------------------------------------------------------------------
r238635 | dvossel | 2010-01-08 13:39:30 -0600 (Fri, 08 Jan 2010) | 22
lines

fixes AUDIOHOOK_INHERIT regression

During the process of removing an audiohook from one channel
and attaching it to another the audiohook's status is updated
to DONE and then back to whatever it was previously.  Typically
updating the status after setting it to DONE is not a good idea
because DONE can trigger unrecoverable audiohook destruction
events... because of this a conditional check was added to
audiohook_update_status to explicitly prevent the audiohook
from ever changing after being set to DONE.  It was this check
that prevented audiohook inherit from work properly though.

Now ast_audiohook_move_by_source is treated as a special exception,
as the audiohook must be returned to its previous status after
attaching it to the new channel.  This is only a safe operation
because the audiohook's lock is held the entire time, otherwise
this could cause trouble.

(closes issue https://issues.asterisk.org/view.php?id=16522)
Reported by: corruptor


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=238635 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-08 13:39 svnbot         Checkin                                      
2010-01-08 13:39 svnbot         Note Added: 0116375                          
======================================================================