[asterisk-bugs] [Asterisk-GUI 0014154]: CID bug in macro-trunkdial-failover-0.3

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14154 
====================================================================== 
Reported By:                dkerr
Assigned To:                
====================================================================== 
Project:                    Asterisk-GUI
Issue ID:                   14154
Category:                   Service Providers/Trunks
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Target Version:             2.0.6
Asterisk GUI Version:       I did not set the version :( 
Asterisk Version:           1.4.21.2 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 4389 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-12-31 14:15 CST
Last Modified:              2010-01-07 09:07 CST
====================================================================== 
Summary:                    CID bug in macro-trunkdial-failover-0.3
Description: 
The Macro macro-trunkdial-failover-0.3 assigns CallerID number/name on
outbound calls. It derives CallerID from a number of sources giving
precedent to one assigned specific to the outbound channel.

However, if the call by the primary channel fails due to CONGESTION or
CHANUNAVAIL and the macro then sends the call to the failover channel then
the CallerID is not "recalculated" based upon the new trunk. This could
potentially be a problem as some VoIP providers require that you set
CallerID to a number that matches the DID obtained by them. Routing (or
establishing eligibility for) emergency calling (911, 999) could require
accurate CallerID for the trunk.

Fix is fairly easy... but cumbersome... have to duplicate all of the
callerID setting stuff at the front of the macro again for ARG4.

When I find some time I'll work on a patch.

David
====================================================================== 

---------------------------------------------------------------------- 
 (0116201) dkerr (reporter) - 2010-01-07 09:07
 https://issues.asterisk.org/view.php?id=14154#c116201 
---------------------------------------------------------------------- 
tzafrir, The marco is written to extensions.conf by the GUI. It is defined
in pbx.js (starts around line 95).  Every time the asterisk GUI initializes
it checks for required macros in extensions.conf. if they are not there,
then they are written.

I thought that the above macro code would be pretty easy to insert into
pbx.js (have to add quote to the front and quote comma to the end of every
line) but if you need a patch file then I can create one for you.

Before committing this, however, I would like a second person to review
the code for handling failover callerID setting.  

David 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-07 09:07 dkerr          Note Added: 0116201                          
======================================================================