[asterisk-bugs] [Asterisk 0016416]: [patch] Portability tweaks to contrib/scripts/safe_asterisk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16416 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16416
Category:                   Core/Portability
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-510 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 233774 
Request Review:              
====================================================================== 
Date Submitted:             2009-12-08 17:03 CST
Last Modified:              2010-01-06 17:45 CST
====================================================================== 
Summary:                    [patch] Portability tweaks to
contrib/scripts/safe_asterisk
Description: 
The attached patch addresses several minor issues that have to do with
improving the script's operation on non-Linux platforms:

1) Use mail instead of mailx (the latter supports specifying the subject
with -s)
2) Change several test cases to work with old versions of test
3) Change the invocation of the date(1) command to work with non-GNU
versions
4) Fix some minor bugs (such as the way id(1) is called and the order of
shell output redirects)
5) Improve the error message to be more helpful when/if Asterisk crashes.

There may be other portability issues, but this script has been tested on
OSX, Linux and OpenSolaris and works on those platforms.
====================================================================== 

---------------------------------------------------------------------- 
 (0116178) bklang (reporter) - 2010-01-06 17:45
 https://issues.asterisk.org/view.php?id=16416#c116178 
---------------------------------------------------------------------- 
Thank you very much for making those additional portability changes.  I
only made the changes necessary to get the script to work on my system
while (hopefully) not breaking existing systems.

Regarding https://issues.asterisk.org/view.php?id=1 in your comments, I assume
you are referring to the change to
KILLALLMPG123 switch?  I can understand not wanting to commit that to old
or current versions of Asterisk (especially to be respective of the release
cycle), but is MPG123 even still in use for music on hold?  I thought that
system was deprecated around the time of Asterisk 1.0.  To me the sane(er)
default going forward is try not to kill any processes we did not start.

I will test your patch on my systems as soon as possible and confirm the
changes. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-01-06 17:45 bklang         Note Added: 0116178                          
======================================================================